On Fri, Feb 12, 2016 at 10:13:59AM +0100, Vincent Abriou wrote: > Those patches introduce debugfs for connector, encoder, crtc and planes. > It adds the following entries: > - planes: > gdpx / gdpx_node > hqvdp > cursor > vid > fps_get / fps_show > > - crtc: > mixer_aux / mixer_main > > - encoder: > tvout > > - connectors: > hda > hdmi > dvo Just noticed that all your debugfs files lock dev->struct_mutex. That's pure cargo-cult garbage. Please fix asap and replace the useless locking you have with the right ones where needed (e.g. modeset structures where never protected by dev->struct_mutex). Did someone bother to review the locking in these patches? Thanks, Daniel > > Vincent Abriou (10): > drm/sti: add debugfs entries for HDMI connector > drm/sti: add debugfs entries for DVO connector > drm/sti: add debugfs entries for HDA connector > drm/sti: add debugfs entries for CURSOR plane > drm/sti: add debugfs entries for GDP planes > drm/sti: add debugfs entries for HQVDP plane > drm/sti: add debugfs entries for VID plane > drm/sti: add debugfs entries for MIXER crtc > drm/sti: add debugfs entries for TVOUT encoders > drm/sti: add debugfs fps_show/fps_get mechanism for planes > > drivers/gpu/drm/sti/sti_compositor.c | 4 +- > drivers/gpu/drm/sti/sti_cursor.c | 81 +++++++++++ > drivers/gpu/drm/sti/sti_drv.c | 128 ++++++++++++++++++ > drivers/gpu/drm/sti/sti_dvo.c | 70 ++++++++++ > drivers/gpu/drm/sti/sti_gdp.c | 238 ++++++++++++++++++++++++++++++++ > drivers/gpu/drm/sti/sti_hda.c | 105 ++++++++++++++- > drivers/gpu/drm/sti/sti_hdmi.c | 175 +++++++++++++++++++++++- > drivers/gpu/drm/sti/sti_hdmi.h | 4 +- > drivers/gpu/drm/sti/sti_hqvdp.c | 254 ++++++++++++++++++++++++++++++++++- > drivers/gpu/drm/sti/sti_mixer.c | 146 +++++++++++++++++++- > drivers/gpu/drm/sti/sti_mixer.h | 4 +- > drivers/gpu/drm/sti/sti_plane.c | 63 +++++++++ > drivers/gpu/drm/sti/sti_plane.h | 17 +++ > drivers/gpu/drm/sti/sti_tvout.c | 157 ++++++++++++++++++++++ > drivers/gpu/drm/sti/sti_vid.c | 94 ++++++++++++- > drivers/gpu/drm/sti/sti_vid.h | 4 +- > 16 files changed, 1524 insertions(+), 20 deletions(-) > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
