Hi Tomi, Thank you for the patch. On Monday 18 Apr 2016 18:42:11 Tomi Valkeinen wrote: > With certain kernel config options many omapdrm files fail to compile > due to missing include of linux/gpio/consumer.h and linux/of.h. > > This patch adds those includes. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Reported-by: Dan Murphy <dmurphy@xxxxxx> > --- > drivers/gpu/drm/omapdrm/displays/encoder-opa362.c | 1 + > drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 + > drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 1 + > drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c | 1 + > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 1 + > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c > b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c index > 8c246c213e06..9f06a87e80c4 100644 > --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c > +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c > @@ -15,6 +15,7 @@ > */ > > #include <linux/gpio.h> This driver uses the gpiod API only, you can remove gpio.h and of_gpio.h. > +#include <linux/gpio/consumer.h> > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index > e780fd4f8b46..ddf4f3be9a3d 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > @@ -10,6 +10,7 @@ > */ > > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c > b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c index > 458f77bc473d..ac680e1de603 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c > @@ -15,6 +15,7 @@ > #include <linux/spi/spi.h> > #include <linux/mutex.h> > #include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > > #include <video/omapdss.h> > #include <video/omap-panel-data.h> > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c > b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c index > 529a017602e4..1de5146c83c0 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c > @@ -11,6 +11,7 @@ > > #include <linux/delay.h> > #include <linux/gpio.h> Same here. With that fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > +#include <linux/gpio/consumer.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_gpio.h> > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index f892ae157ff3..eef260ff420d > 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > @@ -33,6 +33,7 @@ > #include <linux/gpio.h> > #include <linux/regulator/consumer.h> > #include <linux/component.h> > +#include <linux/of.h> > #include <video/omapdss.h> > #include <sound/omap-hdmi-audio.h> > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > b/drivers/gpu/drm/omapdrm/dss/hdmi5.c index a43f7b10e113..417dff5eb7cb > 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c > @@ -38,6 +38,7 @@ > #include <linux/gpio.h> > #include <linux/regulator/consumer.h> > #include <linux/component.h> > +#include <linux/of.h> > #include <video/omapdss.h> > #include <sound/omap-hdmi-audio.h> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
