On Tue, Mar 29, 2016 at 02:21:38PM +0200, Daniel Vetter wrote:
> Accidentally fell through the cracks in
>
> commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> Author: Alexey Brodkin <Alexey.Brodkin@xxxxxxxxxxxx>
> Date: Wed Mar 23 11:42:54 2016 +0300
>
> drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()
>
> despite that Boris acked that patch.
>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Cc: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 3d8d16402d07..8ab4318e57a1 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -615,7 +615,7 @@ err:
> static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
> {
> mutex_lock(&dev->mode_config.mutex);
> - drm_connector_unplug_all(dev);
> + drm_connector_unregister_all(dev);
> mutex_unlock(&dev->mode_config.mutex);
> }
>
I think the locking here is completely unnecessary, since
drm_connector_unregister_all() doesn't actually do anything with the
connector object as far as DRM device is concerned, it merely removes it
from sysfs and debugfs.
But given that I sent out almost the same patch earlier, and this does
fix a build failure:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
