Re: drm: fix blob pointer check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey

On Fri, Mar 11, 2016 at 12:52 PM, Lionel Landwerlin
<lionel.g.landwerlin@xxxxxxxxx> wrote:
> Thanks a lot for pointing this out. I saw you previous comment but didn't
> realize the issue.
> I'll set the pointer to NULL.
>
> I don't if there is an agreement on this, but do you think the unref/free
> functions should check for error pointers?

This is what we did so far, and I'd recommend keeping it for now:

        r = PTR_ERR(foobar);
        foobar = NULL;
        goto error;

As an option, stop overloading pointers and return them like everyone
else does: as a double-pointer in an output argument. This ERR_PTR()
craziness needs to stop.

David
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux