Hi Tomi, Thank you for the patch. On Monday 22 February 2016 19:10:20 Tomi Valkeinen wrote: > omapdrm and omapfb still share the same include/video/omapdss.h. We need > to change that so that we can proceed with omapdrm work. > > However, it's not trivial to make separate omapfb and omapdrm versions > of omapdss.h, as that file is also included in other places like arch > code, audio code and omap_vout code. So we'll do it piece by piece. > > This patch makes private versions of all the dispc function declarations > that are in omapdss.h. For omapdrm we create a new file, > drivers/gpu/drm/omapdrm/dss/omapdss.h, which will contain headers meant > to be visible outside omapdss. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> This looks good to me, but I would squash patches 14/42 to 16/42 together, as it will make it easier to review them and make sure everything relevant has been moved. Could you also confirm that the idea is to move anything that is not needed by arch/ code away from include/video/omapdss.h ? > --- > drivers/gpu/drm/omapdrm/dss/dss.h | 2 + > drivers/gpu/drm/omapdrm/dss/omapdss.h | 61 +++++++++++++++++++++++++ > drivers/gpu/drm/omapdrm/omap_drv.h | 2 + > drivers/video/fbdev/omap2/omapfb/dss/dispc.h | 1 + > drivers/video/fbdev/omap2/omapfb/dss/dss.h | 38 +++++++++++++++++ > include/video/omapdss.h | 38 ----------------- > 6 files changed, 104 insertions(+), 38 deletions(-) > create mode 100644 drivers/gpu/drm/omapdrm/dss/omapdss.h [snip] > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.h > b/drivers/video/fbdev/omap2/omapfb/dss/dispc.h index > 483744223dd1..e014d0419c58 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/dispc.h > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dispc.h > @@ -915,4 +915,5 @@ static inline u16 DISPC_MFLAG_THRESHOLD_OFFSET(enum > omap_plane plane) return 0; > } > } > + > #endif Unrelated change ? -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
