Hi Tomi, On Thursday 03 March 2016 20:54:27 Tomi Valkeinen wrote: > On 03/03/16 20:44, Laurent Pinchart wrote: > > On Thursday 03 March 2016 16:01:16 Tomi Valkeinen wrote: > >> Having -Werror in the omapdrm Makefile makes development and debugging a > >> PITA. Let's remove it. > > > > Well, shouldn't we target having no warning ? :-) > > Yes, but we don't need to make errors of warnings to do that. > > I'm just too tired of trying to avoid warnings when doing new > development or debugging or testing something. > > Too often I have wanted to comment out a line to test something, only to > find out I need to comment out lots of other things too, just to get rid > of "unused variable" warning. > > Or developing a new feature, knowing it's not ready but want to test it > anyway, but even a single warning stops compilation. Fair enough. It could still be interesting to treat warnings as errors by default, but not specifically for the omapdrm driver, so I'm fine with this patch. Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
