... and yet one more round. Changes since v3: - 21/22 "drm/tilcdc: Initialize crtc->port" - Return an error and don't use scary WARN but simple dev_err() instead - 22/22 "drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data" - Tested module loading and unloading with all relevant (and prbably some unrelevant) memory debugging option on. No problem found in the patch. However, there is something fishy either in the component framework or in the way tilcdc used, but that is another story. One more round to fix the last issues commented by Tomi Valkeinen. Changes since v2: - 09/22 "drm/tilcdc: Allocate register storage based on the actual number registers" - Fixed typo in the description - 21/22 "drm/tilcdc: Initialize crtc->port" - Changed the code to handle a port-node that is put in side a ports-node - Removed dev_warn(), and use WARN_ON() instead - Added more details in description - 22/22 "Use devm_kzalloc() and devm_kcalloc() for private data" - New patch Changes since the first version of the series: - Dropped: "drm/tilcdc: disable console switching during pm operations" - Changed: "drm/tilcdc: Allocate register storage based on the actual number.." - Reversed kcalloc() nmemb and size parameters to correct order - Added: "drm/tilcdc: Initialize crtc->port" We have not been too active in pushing the tilcdc fixes to mainline. This series tries to bring the mainline tilcdc upto same level with TI ti-linux tree. Some patches that touch the same place over and over again have been squashed into one, leaving author of the last rewrite on top. Best regards, Jyri Darren Etheridge (4): drm/tilcdc: rewrite pixel clock calculation drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected drm/tilcdc: make frame_done interrupt active at all times drm/tilcdc: disable the lcd controller/dma engine when suspend invoked Dave Gerlach (1): drm/tilcdc: adopt pinctrl support Grygorii Strashko (1): drm/tilcdc: fix build error when !CONFIG_CPU_FREQ Jyri Sarha (8): drm/tilcdc: Implement dma-buf support for tilcdc drm/tilcdc: Allocate register storage based on the actual number registers drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[] drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts drm/tilcdc: Disable sync lost interrupt if it fires on every frame drm/tilcdc: Initialize crtc->port drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data Tomi Valkeinen (8): drm/tilcdc: verify fb pitch drm/tilcdc: cleanup runtime PM handling drm/tilcdc: disable crtc on unload drm/tilcdc: split reset to a separate function drm/tilcdc: remove broken error handling drm/tilcdc: cleanup irq handling drm/tilcdc: Get rid of complex ping-pong mechanism drm/tilcdc: Do not update the next frame buffer close to vertical blank drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 313 ++++++++++++++++++++++----------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 130 ++++++++------ drivers/gpu/drm/tilcdc/tilcdc_drv.h | 5 +- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 20 +-- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 24 +-- 5 files changed, 300 insertions(+), 192 deletions(-) -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel