Hi Alex, On Wed, Feb 24, 2016 at 3:48 PM, Deucher, Alexander <Alexander.Deucher@xxxxxxx> wrote: >> -----Original Message----- >> From: Geert Uytterhoeven [mailto:geert+renesas@xxxxxxxxx] >> Sent: Wednesday, February 24, 2016 3:14 AM >> To: David Airlie; Deucher, Alexander; Bayyavarapu, Maruthi >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Geert >> Uytterhoeven >> Subject: [PATCH] drm/amd: Do not make DRM_AMD_ACP default to y >> >> By default, not only this driver is enabled on all platforms, but also >> generic PM Domains and Multi-Function Devices. >> >> Drop the "default y" to fix this. > > I guess I don't really care per se, but why is this an issue? Because it causes kernel bloat on all platforms that are not AMD SoCs. I noticed the option and the selected options were suddenly enabled when running "make ARCH=sh se7724_defconfig". As a general use, never use "default y", unless the system fails completely in the absence of the module. Even then, there should be some dependencies listed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
