On 24/02/16 00:42, Laurent Pinchart wrote:
>> -void omap_gem_op_update(void)
>
> The function is still referenced from a comment above omap_gem_op_async().
Right. I changed the comment to refer to omap_gem_op_finish().
>> -int omap_gem_set_sync_object(struct drm_gem_object *obj, void *syncobj)
>
> And this one from a comment in the omap_gem_object() structure.
Yep. I think almost all of the comment can be just removed, as SGX no
longer uses this:
@@ -105,17 +105,7 @@ struct omap_gem_object {
* sync-object allocated on demand (if needed)
*
* Per-buffer sync-object for tracking pending and completed hw/dma
- * read and write operations. The layout in memory is dictated by
- * the SGX firmware, which uses this information to stall the command
- * stream if a surface is not ready yet.
- *
- * Note that when buffer is used by SGX, the sync-object needs to be
- * allocated from a special heap of sync-objects. This way many sync
- * objects can be packed in a page, and not waste GPU virtual address
- * space. Because of this we have to have a omap_gem_set_sync_object()
- * API to allow replacement of the syncobj after it has (potentially)
- * already been allocated. A bit ugly but I haven't thought of a
- * better alternative.
+ * read and write operations.
*/
struct {
uint32_t write_pending;
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
