On 24/02/16 00:43, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Friday 19 February 2016 11:47:53 Tomi Valkeinen wrote: >> omap_crtc_wait_pending() waits until the config changes have been taken >> into use, usually at next vblank. The wait-timeout used is 50ms, which >> usually is enough, but in some rare cases not. >> >> As time wait-timeout is just a safety measure for cases where something >> is broken, we can just as well increase the timeout considerably. > > Would it make sense to capture this in a comment in the code ? > > Apart from that, > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I added a comment: /* * timeout is set to a "sufficiently" high value, which should cover * a single frame refresh even on slower displays. */ Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
