Re: [PATCH v10 03/13] drm/mediatek: Add DSI sub driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philipp,

I tried using this driver with the Jitao Shi's latest Parade PS8640
driver from [0], which is based on Archit's recent DRM/DSI patch set
[1], and the parade bridge driver fails to find its DSI host using
of_find_mipi_dsi_host_by_node().

[0 ]https://patchwork.kernel.org/patch/8199281/
[1] https://patchwork.kernel.org/patch/8289181/

This is because mtk_dsi_probe() does not call mipi_dsi_host_register()
to add itself to the host list.

One more small comment below...

On Thu, Feb 4, 2016 at 3:25 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> From: CK Hu <ck.hu@xxxxxxxxxxxx>
>
> This patch add a drm encoder/connector driver for the MIPI DSI function
> block of the Mediatek display subsystem and a phy driver for the MIPI TX
> D-PHY control module.
>
> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> --
> Changes since v9:
>  - don't crash on cleanup if the connector setup was delegated to the bridge
>  - various fixes
> ---
>  drivers/gpu/drm/mediatek/Kconfig       |   3 +
>  drivers/gpu/drm/mediatek/Makefile      |   4 +-
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c |   2 +
>  drivers/gpu/drm/mediatek/mtk_drm_drv.h |   2 +
>  drivers/gpu/drm/mediatek/mtk_dsi.c     | 866 +++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/mediatek/mtk_dsi.h     |  58 +++

Everything defined in mtk_dsi.h can be moved to mtk_dsi.c, and the .h
file can be deleted.

-Dan
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux