Re: [PATCH] radeon: Define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP for consistency and readability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.02.2016 09:29, Alexandre Demers wrote:
> ---
>  drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>  include/uapi/drm/radeon_drm.h          | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
> index 801dd60..c88f9fe 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -1287,7 +1287,7 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc,
>  			} else {
>  				switch (target_fb->bits_per_pixel) {
>  				case 8:
> -					index = 10;
> +					index = SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP;
>  					break;
>  				case 16:
>  					index = SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP;
> diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm.h
> index ccb9bcd..407a092 100644
> --- a/include/uapi/drm/radeon_drm.h
> +++ b/include/uapi/drm/radeon_drm.h
> @@ -1057,6 +1057,7 @@ struct drm_radeon_info {
>  #define SI_TILE_MODE_COLOR_2D_16BPP		15
>  #define SI_TILE_MODE_COLOR_2D_32BPP		16
>  #define SI_TILE_MODE_COLOR_2D_64BPP		17
> +#define SI_TILE_MODE_COLOR_2D_SCANOUT_8BPP	10
>  #define SI_TILE_MODE_COLOR_2D_SCANOUT_16BPP	11
>  #define SI_TILE_MODE_COLOR_2D_SCANOUT_32BPP	12
>  #define SI_TILE_MODE_DEPTH_STENCIL_1D		4
> 

The shortlog (subject line) is a bit long, but other than that,

Reviewed-by: Michel Dänzer <michel.daenzer@xxxxxxx>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux