On 12 February 2016 at 03:19, Harry Wentland <harry.wentland@xxxxxxx> wrote: > This set of patches enables the new DAL display driver for amdgpu on Carrizo > Tonga, and Fiji ASICs. This driver will allow us going forward to bring > display features on the open amdgpu driver (mostly) on par with the Catalyst > driver. > > This driver adds support for > - Atomic KMS API > - MST > - HDMI 2.0 > - Better powerplay integration > - Support of HW bandwidth formula on Carrizo > - Better multi-display support and handling of co-functionality > - Broader support of display dongles > - Timing synchronization between DP and HDMI > > This patch series is based on Alex Deucher's drm-next-4.6-wip tree. > So the first minor criticism is this patch doesn't explain WHY. Why does the Linux kernel need 93k lines of code to run the displays when whole drivers don't even come close. We've spent a lot of time ripping abstraction layers out of drivers (exynos being the major one), what benefits does this major change bring to the Linux kernel and the AMDGPU driver over and above a leaner, more focused work. If were even to consider merging this it would be at a guess considered staging level material which would require a TODO list of major cleanups. I do realise you've put a lot of work into this, but I think you are going to get a lot of review pushback in the next few days and without knowing the reasons this path was chosen it is going to be hard to take. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
