On Wed, Feb 10, 2016 at 04:10:39PM +0000, Carlos Palminha wrote:
> Other bridge drivers don't implement this optional function.
> Removed dummy code from dw-hdmi brigde driver.
>
> Signed-off-by: Carlos Palminha <palminha@xxxxxxxxxxxx>
Merged your three patches to remove dummy mode_fixup functions. I've also
squashed in a fixup for your encoder_funcs->mode_fixup patch. But that
part (i.e. drm_encoder and drm_crtc ->mode_fixup plus dummy func removal)
isn't complete yet. Are you still looking into that some more?
Thanks, Daniel
> ---
> drivers/gpu/drm/bridge/dw-hdmi.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index b0aac473..9795b72 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1391,13 +1391,6 @@ static void dw_hdmi_bridge_mode_set(struct drm_bridge *bridge,
> mutex_unlock(&hdmi->mutex);
> }
>
> -static bool dw_hdmi_bridge_mode_fixup(struct drm_bridge *bridge,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - return true;
> -}
> -
> static void dw_hdmi_bridge_disable(struct drm_bridge *bridge)
> {
> struct dw_hdmi *hdmi = bridge->driver_private;
> @@ -1546,7 +1539,6 @@ static const struct drm_bridge_funcs dw_hdmi_bridge_funcs = {
> .pre_enable = dw_hdmi_bridge_nop,
> .post_disable = dw_hdmi_bridge_nop,
> .mode_set = dw_hdmi_bridge_mode_set,
> - .mode_fixup = dw_hdmi_bridge_mode_fixup,
> };
>
> static irqreturn_t dw_hdmi_hardirq(int irq, void *dev_id)
> --
> 2.5.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
