Hi Corbin, On Sat, Feb 12, 2011 at 10:13:04AM -0800, Corbin Simpson wrote: > On Fri, Feb 11, 2011 at 7:29 PM, Kees Cook <kees.cook@xxxxxxxxxxxxx> wrote: > > In the continuing effort to avoid kernel addresses leaking to unprivileged > > users, this patch switches to %pK for /proc/dri/*/vma. > > This is a highly reasonable patch. Does 0x%pK show up as 0x0x0 in the > log, or just 0x0? Other than that... > Reviewed-by: Corbin Simpson <MostAwesomeDude@xxxxxxxxx> Thanks! The default for %p (and %pK) is without the 0x prefix, and 0-padded to sizeof(void*) character. So 0x%pK will show as 0x00000000 on 32bit to a regular user, etc. -Kees -- Kees Cook Ubuntu Security Team _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
