Re: [PATCH 1/1] Use cachable mapping for i915 opregion.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 23 Jan 2011 21:52:27 +0100, "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> On Sunday, January 23, 2011, Chris Wilson wrote:
> > On Sun, 23 Jan 2011 18:23:34 +0100, Michael Karcher <kernel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > The opregion is a shared memory region between ACPI and the graphics
> > > driver. As the ACPI mapping has been changed to cachable in commit
> > > 6d5bbf00d251cc73223a71422d69e069dc2e0b8d, mapping the intel opregion
> > > non-cachable now fails. As no bus-master hardware is involved in the
> > > opregion, cachable map should do no harm.
> > 
> > Satisfied myself that is indeed equivalent to use the newly introduced
> > acpi_os_ioremap for this purpose and applied to -fixes.
> 
> However, it might be better to use acpi_os_ioremap() in case we decide to
> go back to ioremap() for some reason.  For now, ioremap_cache() seems fine,
> but ...

Great minds think a like, but fools rarely differ...
http://git.kernel.org/?p=linux/kernel/git/ickle/drm-intel.git;a=commit;h=94b3eb7a71fe62f19c91c39dd94c83786108d626
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux