On Wed, Dec 29, 2010 at 21:16, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Wed, 29 Dec 2010 11:40:04 -0800 > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: >> Chris - why did that lvds_ssc_freq thing suddenly start mattering? Can >> we please just disable spread-spectrum entirely? Or perhaps only if we >> notice that it was enabled already? Or something? > > Randy, Jeff and Alex, does the below help at all? ÂIf so, it may be the > minimal fix we want for 2.6.37. Something broke your patch: whitespace instead of tabs. > diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios > index 2b20786..d27d016 100644 > --- a/drivers/gpu/drm/i915/intel_bios.c > +++ b/drivers/gpu/drm/i915/intel_bios.c > @@ -263,6 +263,9 @@ parse_general_features(struct drm_i915_private *dev_priv, > Â Â Â Â Â Â Â Âdev_priv->int_tv_support = general->int_tv_support; > Â Â Â Â Â Â Â Âdev_priv->int_crt_support = general->int_crt_support; > Â Â Â Â Â Â Â Âdev_priv->lvds_use_ssc = general->enable_ssc; > + Â Â Â Â Â Â Â /* force disable until we can parse this correctly */ This comment seems to imply that SSC wasn't used at all until recently, right? > + Â Â Â Â Â Â Â if (IS_GEN5(dev) || IS_GEN6(dev)) > + Â Â Â Â Â Â Â Â Â Â Â dev_priv->lvds_use_ssc = 0; Doesn't change anything here. Display stays blank. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
