Re: [PATCH] drm/radeon/kms: only enable underscan by default if the monitor supports audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/12/17 Alex Deucher <alexdeucher@xxxxxxxxx>:
> Users with TVs or monitors that don't overscan by default would prefer
> to not have underscan enabled, while users with overscanning TVs prefer
> underscan. ÂThis should hopefully make everyone happy as most monitors
> with audio tend to be TVs which overscan by default and monitors without
> audio don't overscan. ÂUnderscan can still be overriden by changing the
> connector attribute.
>
> Signed-off-by: Alex Deucher <alexdeucher@xxxxxxxxx>
> ---
> Âdrivers/gpu/drm/radeon/radeon_display.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index a26c1c3..3bca929 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1307,7 +1307,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â(!(mode->flags & DRM_MODE_FLAG_INTERLACE)) &&
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â((radeon_encoder->underscan_type == UNDERSCAN_ON) ||
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) &&
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â drm_detect_hdmi_monitor(radeon_connector->edid) &&
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â drm_detect_monitor_audio(radeon_connector->edid) &&
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âis_hdtv_mode(mode)))) {
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âif (radeon_encoder->underscan_hborder != 0)
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âradeon_crtc->h_border = radeon_encoder->underscan_hborder;

I don't like it. My TV supports audio and doesn't perform any stupid
overscanning by default. It's SONY Bravia 52''.

-- 
RafaÅ
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux