2010/12/16 Mark Marshall <mark.marshall@xxxxxxx>:
> On 16/12/2010 05:54, Dave Airlie wrote:
>>
>> From: Dave Airlie<airlied@xxxxxxxxxx>
>> Âint pci_set_vga_state(struct pci_dev *dev, bool decode,
>> - Â Â Â Â Â Â Â Â Â Â unsigned int command_bits, bool change_bridge)
>> + Â Â Â Â Â Â Â Â Â Â unsigned int command_bits, u32 flags)
>> Â{
>> Â Â Â Âstruct pci_bus *bus;
>> Â Â Â Âstruct pci_dev *bridge;
>> Â Â Â Âu16 cmd;
>> Â Â Â Âint rc;
>>
>> - Â Â Â WARN_ON(command_bits& Â~(PCI_COMMAND_IO|PCI_COMMAND_MEMORY));
>> + Â Â Â WARN_ON((flags& ÂPCI_VGA_STATE_CHANGE_DECODES)& Â(command_bits&
>> Â~(PCI_COMMAND_IO|PCI_COMMAND_MEMORY)));
>
> Minor thing, but I think the middle & should be a &&?
Dave: as you are going to fix patch, please add spaces around "|" by the way:
PCI_COMMAND_IO|PCI_COMMAND_MEMORY
--
RafaÅ
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
