On Thu, Dec 2, 2010 at 5:38 AM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 1 Dec 2010 17:54:18 +0100 > Julien Cristau <jcristau@xxxxxxxxxx> wrote: > >> On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote: >> >> > For headers that get exported to userland and make use of u32 style >> > type names, it is advised to include linux/types.h. >> > >> > This fixes 5 headers_check warnings. >> > >> How many times does this need to be NAKed? > > Until someone gets a clue and puts comments in there explaining this? how about someone fixing the dumb scripts to understand that C header includes aren't single level. Like 10 people have posted this patch and not one has come back with a fix for the app after I pointed it out, like really if people think they can write C good enough to send kernel patches, maybe they could put some more effort in and actually fix a real problem. We should start hashing signed-off-by's so people can't get any glory from them. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel