On Tue, Nov 16, 2010 at 6:30 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Tue, Nov 16, 2010 at 06:05:25PM +0100, Sedat Dilek wrote: >> I have tested both patchsets from Daniel (see [1] and [2]) again on a >> Radeon RV250 in a none-BKL-config and it looks like >> >> Â Â Â Âagd5f-pflip/0002-drm-radeon-kms-add-pageflip-ioctl-support.patch >> >> is the culprit in combination with the below listed drm patches. > Likely a gem_bo->driver_private access. My patches set this to NULL to > catch conversion bugs. > -Daniel > -- > Daniel Vetter > Mail: daniel@xxxxxxxx > Mobile: +41 (0)79 365 57 48 > [ CCing Alex Deucher ] With the attached diff to the original patch from [1], OpenArena works with pageflip-support for radeon-KMS. Unfortunately, there is a drop in fps from 18.5 down to 13.5. - Sedat - [1] http://people.freedesktop.org/~agd5f/pflip/0002-drm-radeon-kms-add-pageflip-ioctl-support.patch $ cd ~/src/linux-2.6/linux-2.6.37-rc2/debian/build/source_i386_none/ $ cat .pc/applied-patches danvet-drm-for-sedat-dilek/0001-drm-nouveau-don-t-munge-in-drm_mm-internals.patch danvet-drm-for-sedat-dilek/0002-drm_mm-add-support-for-range-restricted-fair-lru-sca.patch danvet-drm-for-sedat-dilek/0003-drm-mm-track-free-areas-implicitly.patch danvet-drm-for-sedat-dilek/0004-drm-mm-extract-node-insert-helper-functions.patch danvet-drm-for-sedat-dilek/0005-drm-mm-add-api-for-embedding-struct-drm_mm_node.patch danvet-drm-for-sedat-dilek/0006-drm-mm-add-helper-to-unwind-scan-state.patch danvet-embed-drm_gem_object-into-radeon_bo/1-3-drm-radeon-embed-struct-drm_gem_object.patch danvet-embed-drm_gem_object-into-radeon_bo/2-3-drm-radeon-introduce-gem_to_radeon_bo-helper.patch danvet-embed-drm_gem_object-into-radeon_bo/3-3-drm-radeon-kill-radeon_bo--gobj-pointer.patch drm-vblank-timestamping/0001-drm-vblank-Add-support-for-precise-vblank-timestampi.patch drm-vblank-timestamping/0002-drm-radeon-Add-support-for-precise-vblank-timestampi.patch for-drm-radeon-testing/drm-radeon-kms-enable-writeback-on-radeon-AGP-boards.patch agd5f-pflip/0002-drm-radeon-kms-add-pageflip-ioctl-support-for-danvet-v2.patch $ cd ~/src/mesa/ $ ./scripts/run_openarena-benchmark.sh 840 frames 62.6 seconds 13.4 fps 16.0/74.5/224.0/19.7 ms
diff -Naur 0002-drm-radeon-kms-add-pageflip-ioctl-support.patch 0002-drm-radeon-kms-add-pageflip-ioctl-support-for-danvet-v2.patch --- 0002-drm-radeon-kms-add-pageflip-ioctl-support.patch 2010-10-31 18:53:38.000000000 +0100 +++ 0002-drm-radeon-kms-add-pageflip-ioctl-support-for-danvet-v2.patch 2010-11-16 20:07:12.380393000 +0100 @@ -1319,7 +1319,7 @@ + new_radeon_fb = to_radeon_framebuffer(fb); + /* schedule unpin of the old buffer */ + obj = old_radeon_fb->obj; -+ rbo = obj->driver_private; ++ rbo = gem_to_radeon_bo(obj); + work->old_rbo = rbo; + INIT_WORK(&work->work, radeon_unpin_work_func); + @@ -1338,7 +1338,7 @@ + + /* pin the new buffer */ + obj = new_radeon_fb->obj; -+ rbo = obj->driver_private; ++ rbo = gem_to_radeon_bo(obj); + r = radeon_bo_reserve(rbo, false); + if (unlikely(r != 0)) + goto pflip_cleanup;
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
