Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun,  3 Oct 2010 00:33:06 -0700
Keith Packard <keithp@xxxxxxxxxx> wrote:

> Instead of waiting for the display line value to settle, we can simply
> wait for the pipe configuration register 'state' bit to turn off.
> 
> Contrarywise, disabling the plane will not cause the display line
> value to stop changing, so instead we wait for the vblank interrupt
> bit to get set. And, we only do this when we're not about to wait for
> the pipe to turn off.
> 
> Signed-off-by: Keith Packard <keithp@xxxxxxxxxx>
> ---

Do these fixes help with the DP issues you've been seeing, Keith?
Seems like the first one shouldn't change behavior since we ought to
time out on waiting on vblank in that case, and the timeout is the same
as the msleep we used to use.

The second one looks like a good change, but really the pipe off change
is separate from the plane disable bug fix.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux