Re: [patch] radeon: handle errors in radeon_hwmon_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/8/8 Dan Carpenter <error27@xxxxxxxxx>:
> Smatch complained that the ERR_PTR from hwmon_device_register() wasn't
> handled.  I added some error handling in radeon_hwmon_init() to silence
> the warning.
>
> Unfortunately errors from radeon_pm_init() aren't handled so this
> doesn't really make a difference beyond silencing the warning.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Didn't we try to switch from DRM_ERROR to dev_err? I think that's
preferred method.

-- 
Rafał
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux