On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter <error27@xxxxxxxxx> wrote: > intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as > opposed to drm_gem_object_unreference_unlocked()) so it needs to be > called with "struct_mutex" held. If we don't hold the lock, it triggers > a BUG_ON(!mutex_is_locked(&dev->struct_mutex)); > > I also audited the other places that call intel_cleanup_ring_buffer() > and they all hold the lock so they're OK. > > This was introduced in: 8187a2b70e3 "drm/i915: introduce > intel_ring_buffer structure (V2)" and it's a regression from v2.6.34. > > Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16247 > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > Reported-by: Benny Halevy <bhalevy@xxxxxxxxxxx> > Tested-by: Benny Halevy <bhalevy@xxxxxxxxxxx> Applied to for-linus. Thanks!
Attachment:
pgpOccAAr8qDs.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
