Re: [PATCH]: i915: Fix missing linux/types.h warning in header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Prarit Bhargava wrote:
Fixes warning:

/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include<linux/types.h>

Signed-off-by: Prarit Bhargava<prarit@xxxxxxxxxx>

diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index b64a8d7..5cf7f5b 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@ -27,6 +27,7 @@
  #ifndef _I915_DRM_H_
  #define _I915_DRM_H_

+#include<linux/types.h>
  #include "drm.h"
drm.h includes it, safely tucked inside #ifdef __linux__ so it won't
break BSD&  OpenSolaris DRI builds - isn't that good enough?

Hmm ... it doesn't appear to be :/  From a week-old compile of linux-next

/home/linux-next/usr/include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>

It could certainly be that the error check is busted ...

P.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux