Re: [PATCH] drm/radeon/kms: fix tv dac conflict resolver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il giorno dom, 02/05/2010 alle 13.59 +0200, GhePeU ha scritto:
> Il giorno dom, 02/05/2010 alle 20.46 +1000, Dave Airlie ha scritto:
> > On Sun, May 2, 2010 at 7:42 PM, GhePeU <ghepeu@xxxxxxxxxxx> wrote:
> > > Il giorno dom, 02/05/2010 alle 19.11 +1000, Dave Airlie ha scritto:
> > >> On Sat, May 1, 2010 at 10:42 PM, GhePeU <ghepeu@xxxxxxxxxxx> wrote:
> > >> >
> > >> > Would it be possible to add a module option to disable tv load
> > >> > detection? As things are now I must always change back the resolution to
> > >> > 1440x900 and disable the TV.
> > >>
> > >> try booting with video=TV-1:d
> > 
> > oh try video=DIN-1:d
> > 
> > or S-video-1:d, have a look in /sys/class/drm when booted for the correct one.
> > 
> > Dave.
> 
> /sys/class/drm lists "card0-SVIDEO-1", dmesg has "S-video" and the
> encoder is "TV1". I booted with "video=SVIDEO-1:d", "video=S-video:d",
> "video=TV1:d" and finally "video=S-video-1:d" but none of them worked.
> 
> I'll look to the source code when I'll have the time.
> 
> Giacomo
> 

Looking to radeon_connector.c I found that TV load detection had already
been disabled for some other chipsets because it wasn't always reliable.
I just added my card's family to the check (patch attached) and now my
problem's gone.

Disabling TV detection for the entire family is probably overkill, just
blacklisting my card (a Radeon Sapphire X550 Silent, 1002:5b63) would've
been enough, is there another place where this quirk could be added?

Giacomo 
--- a/drivers/gpu/drm/radeon/radeon_connectors.c	2010-05-02 16:28:30.123432476 +0200
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c	2010-05-02 17:46:25.026128098 +0200
@@ -1337,7 +1337,7 @@
 			 * found a way to make load detect reliable on those
 			 * chipset, thus just disable it for TV.
 			 */
-			if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480)
+			if (rdev->family == CHIP_RS400 || rdev->family == CHIP_RS480 || rdev->family == CHIP_RV380)
 				radeon_connector->dac_load_detect = false;
 			drm_connector_attach_property(&radeon_connector->base,
 						      rdev->mode_info.load_detect_property,
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux