On Don, 2010-04-29 at 14:02 +0200, Daniel Vetter wrote: > On Thu, Apr 29, 2010 at 11:32:36AM +0200, Michel Dänzer wrote: > > On Don, 2010-04-29 at 11:14 +0200, Daniel Vetter wrote: > > > The information supplied by userspace through these ioctls is only > > > accessible by dev->drw_idr. But there's no in-tree user of that. > > > Information might also leak via the RM_DRAW ioctl (in the form of > > > a negative return code in case the drawable doesn't exist). But the > > > only user of these ioctls, mesas' miniglx, does not use the RM_DRAW > > > ioctl. > > > > FYI, the X server DRI1 code also uses these ioctls, via the libdrm > > functions drmCreate/DestroyDrawable and drmUpdateDrawableInfo(). > > Thanks, I've overlooked the DRI stuff in the xserver. There, > drmDestroyDrawable is used (but the return code is ignored), so should be > fine. The only place the return value is checked when creating a drawable > for the first time (to free any allocations already made). Should be safe, > too. > > > > Therefore it's safe to replace these three ioctls with noops and rip > > > out the implementation. > > > > That should still true though, as none of the DRM drivers use the > > drawable cliprect information anymore. Might still be worth > > double-checking that this doesn't break DRI without KMS on your RV570. > > I've tried to test DRI1, but that seems to be in a hilariously broken > state on my box: Windows are smeared all over the screen (tiling > parameters mismatch?) under certain circumstances. But glxinfo shows the > correct render string, AIGLX seems to load correctly (according to > Xorg.log) and kde's opengl cover switch looks all right. Also, after some > time it hangs with the dmesg complaining that someone is monopolizing the > heavyweight lock (in drm_lock_take). Results without these patches are > similar. > > I haven't used ums radeon since months, so I don't think you can count > this as useful testing ;) I think it's good enough for the purpose of this change, as I'd expect any problem caused by it to manifest when starting or quitting any 3D app (such as the one doing the OpenGL cover switch). So, here's my Reviewed-by: Michel Dänzer <michel@xxxxxxxxxxx> for it. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
