Hi,
On 2025. 03. 22. 20:13, Christophe JAILLET wrote:
Le 11/03/2025 à 19:02, Bence Csókás a écrit :
Clean up error handling by using devm functions
and dev_err_probe(). This should make it easier
to add new code, as we can eliminate the "goto
ladder" in probe().
Suggested-by: Chen-Yu Tsai <wens@xxxxxxxxxx>
Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>
Signed-off-by: Bence Csókás <csokas.bence@xxxxxxxxx>
---
Notes:
Changes in v2:
* rebase on current next
Changes in v3:
* rebase on current next
* collect Jernej's tag
Changes in v4:
* rebase on current next
* collect Chen-Yu's tag
drivers/dma/sun4i-dma.c | 31 ++++++-------------------------
1 file changed, 6 insertions(+), 25 deletions(-)
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 24796aaaddfa..b10639720efd 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -1249,10 +1249,9 @@ static int sun4i_dma_probe(struct
platform_device *pdev)
if (priv->irq < 0)
return priv->irq;
- priv->clk = devm_clk_get(&pdev->dev, NULL);
+ priv->clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(priv->clk)) {
- dev_err(&pdev->dev, "No clock specified\n");
- return PTR_ERR(priv->clk);
+ return dev_err_probe(&pdev->dev, PTR_ERR(priv->clk),
"Couldn't start the clock");
Why removing the trailing \n everywhere?
Any reference esxplaing why it is correct?
CJ
Well, printk() will add a newline unless LOG_CONT is used. However,
while looking up this feature, it seems that the consensus is to keep
the `\n`s, even though they are not strictly needed anymore. I'll update
this.
Bence
