Re: [PATCH v4] dma-engine: sun4i: Use devm functions in probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Markus,

On 2025. 03. 11. 20:33, Markus Elfring wrote:
>> Clean up error handling by using devm functions
>> and dev_err_probe(). This should make it easier
> …
>
> You may occasionally put more than 47 characters into text lines
> of such a change description.

It was an old patch I hadn't yet reformatted to 75 cols. I used 50-60 cols before, because my mail client's preview panel is very narrow, so anything more than ~65 characters will wrap. If there will be a v5, I'll reformat it to 75 cols as well, as per the style guidelines.

How good does such a change combination fit to the patch requirement
according to separation of concerns?
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc6#n81

It is a general refactor patch, it shouldn't change any functionality. I could split it to one part introducing `devm_clk_get_enabled()` and the other `dmaenginem_async_device_register()`, but I don't feel that to be necessary, nor does it bring any advantages I believe.

Regards,
Markus

Bence





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux