Re: [v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 10 Mar 2025 10:50:06 +0100
In-reply-to: <bb29d6d8-6887-4eed-ba24-7392de9c2c29@linux.alibaba.com>
References: <20250309062058.58910-1-xueshuai@linux.alibaba.com> <20250309062058.58910-2-xueshuai@linux.alibaba.com> <8545206d-4a7d-4e0f-812b-dadf923b5b5c@web.de> <bb29d6d8-6887-4eed-ba24-7392de9c2c29@linux.alibaba.com>
Ui-outboundreport: notjunk:1;M01:P0:W6NfeSMmN+w=;qxZlsgPyzKSrFV/wthu3AQOwx1l VCMLpYzv5nT0zjZpmClTkO1ISvvgpGVtiUZNqo7U1Dz85X+6Jp5p6qkGiCyImlsNQr4kQ1l7t q6iorn3b6Fr0gHR4ErFkMu/o2TspKBgcfbUAYnuWeotS57XtmxPV5nJnOQ0lYrFNZYNZpDdCn EGm3uNyfmPJJa9U4SBX5xDvehkITSJmJr/lBdZOYlJqBZkfhYSX352vRM1+FnTMZ3Cn7pw2fl yF0oBrXE/S8qOFcQttqkWuFpN1UIkxGFSBlA/lw9pFkNUwnKJczydTbw02VAe8dkw2AybK7H8 v9+yk5ddwl7V3SxbfaW+aBOY4emSpwssGYazVcQeT4TpWjlsltSV2bPisOssKYZjKNh5hg+uX Ok9cfc8/16NarI32tTD4I/Aly3PgMo/9Na7++B9NQ82B5tnIkM22mf2V61K0wTo0FjCCgBWJ/ TeiN0mGhHTzpR5lw/oE06xJ+zS4e9aa/3kut4Xq9z5uWIBmcdP7XvdnYt4cg9j2obnhUXT32J lxuJNJlEYeeN9NBuT9jyuFcJXuPQVvzqGxp9TLTOYcwC8QZ5ePjE2g816IPkVvEgCZ5ZNmMpM fs2CknL+/Ktgg+alztg6TEvA4/wrs93Dj+OPfPJCjWGk6HCgRVHsF8QhXdnrYh+qFvwsbAvmm ZFzpJ/0fc5d24IHT3Ms+fxE+L7IYRG1FGKjBfqwcvpGPeBe49A3Li4HCIj77vAsl8QZ5FkT4C 6PeN9gKIKHhlP7ffz1GEMs1skWwAdh51hnKFRzaHNjg4JHL1OpqhzO7lVTor+2Fkmr0xxV4xO WadwI4TPA5j9bOOU6yFcILo59n8Foy+kntpe8csy9+lkXqmY6mugGmC4OLriBPXwrakc+zdgm Owmcg5r8+/Ek3t4nwl4nu7MY0ublE0w810naQ1ltUuW22aikmXpOafY0ytnZ3dWj1Ga3GS9FO 14fVjXx74GLSuNGqqCh8kXBUDENHGn9adbvBhURosZK5YeM3tRRVHlbUyWhzHlCeTkb0eNHah piIJpfHUJRcz5l6bOSmYYEUHdwkDe9v1mk/TzEEL4bw8ku07hhuXhXAntvIhR6T55SaEjf5Zr nxz2XqwIAat81Ay/w/t+hbcYdzNfZkhpXHSkejBR8M8XOD76G4xYE++jFbaC8Tgx4KCC1j3tO +8sEf5sQS72PLF7n759xAGM2xWTYlHduvm67kmGETgTuOI6HuNF/sJY0PVqxc49M/zwL1h4WC pU6F8IfzvbWdMyneKZWuC1R6B0bbAMo0IC+4z5aE8DBKbH2PBeD5kkvszw9upPLFsvejpVVtt yc4l66w4UfjsmEi1RMwME6ZJlYGk6K6e6+Pg4eFLINDfoSKhOBWxN45ANyHtYdKIAus/ZLMJ5 H84It9eJYw3nY0FrnNPUPn0fwySMvSUHgbZ2GGhXH6OfIPlbCQZJ5I5WytownRiHJR0usXUkl 9+H4thQ==
User-agent: Mozilla Thunderbird

> I prefer to set error code before jumping to error handling label
> so that we can extend/change the error code in any future path.
I prefer to avoid duplicate source code another bit.

Regards,
Markus

References:
- [PATCH v3 0/9] dmaengine: idxd: fix memory leak in error handling path
  - From: Shuai Xue
- [PATCH v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs
  - From: Shuai Xue
- Re: [PATCH v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()
  - From: Markus Elfring
- Re: [PATCH v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()
  - From: Shuai Xue

Prev by Date: Re: [PATCH v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()
Next by Date: Re: [PATCH v4] dt-bindings: dma: Convert fsl,elo*-dma to YAML
Previous by thread: Re: [PATCH v3 1/9] dmaengine: idxd: fix memory leak in error handling path of idxd_setup_wqs()
Next by thread: [PATCH v3 4/9] dmaengine: idxd: Add missing cleanup for early error out in idxd_setup_internals
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux PCI] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]