Re: [PATCH 1/3] dt-bindings: dma: fsl-edma: increase maxItems of interrupts and interrupt-names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 28, 2025 at 06:13:50PM +0000, Conor Dooley wrote:
> On Fri, Feb 28, 2025 at 12:42:03PM -0500, Frank Li wrote:
> > From: Joy Zou <joy.zou@xxxxxxx>
> >
> > The edma controller support optional error interrupt, so update interrupts
> > and interrupt-names's maxItems.
>
> This seems like something were you would know based on the soc (or
> compatible) whether or not 64 or 65 is the correct maximum for that
> device?

Not exactly, 64 channel is maxium value, which IP supportted. There are
difference instances in the same SOC. Some may only 31 dma channel, some
may only 12, some have 64. Each channel have one irqs and one shared err
irq.

Ideally it should be property 'dma-channels' + 1. But not sure if schema
can check such case.

Frank

>
> >
> > Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > index 4f925469533e7..900170b3606ef 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > @@ -40,11 +40,11 @@ properties:
> >
> >    interrupts:
> >      minItems: 1
> > -    maxItems: 64
> > +    maxItems: 65
> >
> >    interrupt-names:
> >      minItems: 1
> > -    maxItems: 64
> > +    maxItems: 65
> >
> >    "#dma-cells":
> >      description: |
> >
> > --
> > 2.34.1
> >






[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux