[PATCH v4] dma: dw-axi-dmac: remove unnecessary axi_dma_enable() calling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>

DMA is always enabled before calling axi_chan_block_xfer_start(),
so it does not need to be enabled again here.

Re-enabling DMA causes random failures in the dmatest test when running
multiple iterations.
e.g.
[   29.600722] dmatest: dma0chan2-copy0: summary 100 tests, 1 failures 160.26 iops 1299 KB/s (0)

Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")
Tested-by :Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
---

Changes in v4:
  * Add fixes tag
  * Rebase to v6.14-rc1 

link to v3:
 - https://lore.kernel.org/all/20230521101216.4084-4-jszhang@xxxxxxxxxx/

 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
index b23536645ff7..43d30c7b8f03 100644
--- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
+++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
@@ -435,8 +435,6 @@ static void axi_chan_block_xfer_start(struct axi_dma_chan *chan,
 		return;
 	}
 
-	axi_dma_enable(chan->chip);
-
 	config.dst_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.src_multblk_type = DWAXIDMAC_MBLK_TYPE_LL;
 	config.tt_fc = DWAXIDMAC_TT_FC_MEM_TO_MEM_DMAC;
-- 
2.25.1





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux