num-channels and qcom,num-ees are required for BAM nodes without clock, because the driver cannot ensure the hardware is powered on when trying to obtain the information from the hardware registers. Specifying the node without these properties is unsafe and has caused early boot crashes for other SoCs before [1, 2]. The bam_dma driver has always printed an error to the kernel log in these situations, but that was not enough to prevent people from upstreaming patches without the required properties. To prevent these situations in the future, enforce the presence of the properties in both driver and schema and add the missing properties to the affected platforms. [1]: https://lore.kernel.org/r/CY01EKQVWE36.B9X5TDXAREPF@xxxxxxxxxxxxx/ [2]: https://lore.kernel.org/r/20230626145959.646747-1-krzysztof.kozlowski@xxxxxxxxxx/ Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> --- Luca Weiss (1): arm64: dts: qcom: sm8350: Reenable crypto & cryptobam Stephan Gerhold (7): arm64: dts: qcom: sm8450: Add missing properties for cryptobam arm64: dts: qcom: sm8550: Add missing properties for cryptobam arm64: dts: qcom: sm8650: Add missing properties for cryptobam arm64: dts: qcom: sa8775p: Add missing properties for cryptobam arm64: dts: qcom: ipq9574: Add missing properties for cryptobam dt-bindings: dma: qcom: bam-dma: Add missing required properties dmaengine: qcom: bam_dma: Fix DT error handling for num-channels/ees Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 4 ++++ arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 6 ++---- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 ++ drivers/dma/qcom/bam_dma.c | 8 ++++++-- 8 files changed, 22 insertions(+), 6 deletions(-) --- base-commit: c674aa7c289e51659e40dda0f954886ef7f80042 change-id: 20250204-bam-dma-fixes-1e06f2a6c418 Best regards, -- Stephan Gerhold <stephan.gerhold@xxxxxxxxxx>
