> -----Original Message----- > From: Aatif Mushtaq <aatif4.m@xxxxxxxxxxx> > Sent: Monday, February 10, 2025 11:49 AM > To: vkoul@xxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Cc: pankaj.dubey@xxxxxxxxxxx; aswani.reddy@xxxxxxxxxxx; Aatif Mushtaq > <aatif4.m@xxxxxxxxxxx> > Subject: [PATCH 2/3] dmaengine: pl330: Add DMAADDH instruction > > Add support for emitting DMAADDH instruction. > Add halfword instruction adds an immediate 16-bit value to the source > address register or destination address register for the DMA channel > thread. This enables the DMAC to support 2D DMA operations. > > Signed-off-by: Aatif Mushtaq <aatif4.m@xxxxxxxxxxx> > --- Looks good to me. Reviewed-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>