Hi Krzysztof, On 05/02/25 5:10 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, Feb 05, 2025 at 11:17:03AM +0530, Dharma Balasubiramani wrote: >> Add document for the property "dma-channels" for XDMA controller. > > I don't understand why. You are duplicating dma schema. > > The same as with other patch - your commit msg is redundant. You say > what we see the diff but you never explain why you are doing these > changes. And in both cases this is really non-obvious. > > Apply this feedback to all future contributions - say why you are doing > changes instead of repeating what subject and diff are already saying. Thanks for your feedback, do you want me to include the description of dma-channels from the diff in the commit message? The reason for this change is: "This property is required when the channel count cannot be read from the XDMAC_GTYPE register (which occurs when accessing from the non-secure world on certain devices)." Isn't this already clear from the description in the diff? > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
