Re: [PATCH 7/8] dmaengine: fsl-edma: wait until no hardware request is in progress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/2024 7:27 AM, Krzysztof Kozlowski wrote:
[You don't often get email from krzk@xxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On 16/12/2024 08:58, Larisa Grigore wrote:
Wait DMA hardware complete cleanup work by checking HRS bit before
disabling the channel to make sure trail data is already written to
memory.

Fixes: 72f5801a4e2b7 ("dmaengine: fsl-edma: integrate v3 support")

Why Fixes are at the end of the patchset? They must be either separate
patchset or first patches.

Best regards,
Krzysztof

Thank you for you review Krzysztof! Indeed, this commit should be moved right after "dmaengine: fsl-edma: add eDMAv3 registers to edma_regs" which introduces the eDMA V3 specific registers including HRS.
I will move it in the next version.

Best regards,
Larisa




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux