On 24-11-24, 22:20, Randy Dunlap wrote: > > > On 11/24/24 10:15 PM, Randy Dunlap wrote: > > The comment block for "Interleaved Transfer Request" should not begin > > with "/**" since it is not in kernel-doc format. > > > > Fix doc name for enum sum_check_flags. > > > > Fix all (4) missing struct member warnings. > > > > Use "Warning:" for one "Note:" in enum dma_desc_metadata_mode since > > scripts/kernel-doc does not allow more than one Note: > > per function or identifier description. > > > > This leaves around 49 kernel-doc warnings like: > > include/linux/dmaengine.h:43: warning: Enum value 'DMA_OUT_OF_ORDER' not described in enum 'dma_status' > > > > and another scripts/kernel-doc problem with it not being able to parse > > some typedefs. > > > > Fixes: b14dab792dee ("DMAEngine: Define interleaved transfer request api"), Jassi Brar > > Oops, I left a note in the line above. I'll fix it for v2 after comments. lgt,, I guess we can do a v2 now > > > Fixes: ad283ea4a3ce ("async_tx: add sum check flags") > > Fixes: 272420214d26 ("dmaengine: Add DMA_CTRL_REUSE") > > Fixes: f067025bc676 ("dmaengine: add support to provide error result from a DMA transation") > > Fixes: d38a8c622a1b ("dmaengine: prepare for generic 'unmap' data") > > Fixes: 5878853fc938 ("dmaengine: Add API function dmaengine_prep_peripheral_dma_vec()") > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Cc: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > > Cc: Dave Jiang <dave.jiang@xxxxxxxxx> > > Cc: Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > Cc: Nuno Sa <nuno.sa@xxxxxxxxxx> > > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > > Cc: dmaengine@xxxxxxxxxxxxxxx > > --- > > include/linux/dmaengine.h | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > -- > ~Randy > -- ~Vinod