Re: [PATCH v2 02/10] dma-engine: sun4i: Add has_reset option to quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024. 10. 27. 10:14, Csókás, Bence wrote:
From: Mesih Kilinc <mesihkilinc@xxxxxxxxx>

Allwinner suniv F1C100s has a reset bit for DMA in CCU. Sun4i do not
has this bit but in order to support suniv we need to add it. So add
support for reset bit.

Signed-off-by: Mesih Kilinc <mesihkilinc@xxxxxxxxx>
[ csokas.bence: Rebased and addressed comments ]
Signed-off-by: Csókás, Bence <csokas.bence@xxxxxxxxx>
---

Notes:
     Changes in v2:
     * Call reset_control_deassert() unconditionally, as it supports optional resets
     * Use dev_err_probe()

I missed one, namely:

+		dev_err(&pdev->dev,
+			"Failed to deassert the reset control\n");
+		goto err_clk_disable;
+	}

For now I'll resubmit just this patch, and then wait for more comments that may arise during the week, then resubmit the whole amended series.





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux