On Mon, Oct 07, 2024 at 06:06:46PM +0300, Andy Shevchenko wrote: > Let's reduce the surface of the use of __dma_request_channel(). > Hopefully we can make it internall to the DMA drivers or kill for good > completely. Suggest: Reduce use internal __dma_request_channel() function in public dmaengine.h I think this change is okay, but I hope the following patches, which make __dma_request_channel() as internal only. otherwise, it looks not necessary. Frank > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > include/linux/dmaengine.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index b4e6de892d34..2f46056096d6 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -1639,7 +1639,7 @@ static inline struct dma_chan > if (!fn || !fn_param) > return NULL; > > - return __dma_request_channel(&mask, fn, fn_param, NULL); > + return dma_request_channel(mask, fn, fn_param); > } > > static inline char * > -- > 2.43.0.rc1.1336.g36b5255a03ac >
