Re: [PATCH 1/3] dmaengine: sh: rz-dmac: handle configs where one address is zero

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Now both code paths are identical, not sure may be introducing a helper
> by passing channel, CHCFG_FILL_*_MASK and *_addr_width
> will save some code??

I had a look and I don't think so because we'd need to pass so many
parameters to the helper, that it doesn't really save anything, I'd say.

> Anyway, current code LGTM. So,
> 
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux