Re: [PATCH] dmaengine: idxd: Add a new IAA device ID on Panther Lake family platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/11/24 13:58, Dave Jiang wrote:


On 9/11/24 1:45 PM, Fenghua Yu wrote:
A new IAA device ID, 0xb02d, is introduced across all Panther Lake family
platforms. Add the device ID to the IDXD driver.

Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
---
Hi, Vinod,

This patch is applied cleanly on the next branch in the dmaengine repo.

The next branch already includes a few new DSA/IAA device IDs in IDXD
driver.

Please check the patches and the reasons why the new IDs should be added:
https://lore.kernel.org/lkml/20240828233401.186007-1-fenghua.yu@xxxxxxxxx/

  drivers/dma/idxd/init.c | 2 ++
  include/linux/pci_ids.h | 1 +
  2 files changed, 3 insertions(+)

diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 0f693b27879c..3ae494a7a706 100644
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -78,6 +78,8 @@ static struct pci_device_id idxd_pci_tbl[] = {
  	{ PCI_DEVICE_DATA(INTEL, IAX_SPR0, &idxd_driver_data[IDXD_TYPE_IAX]) },
  	/* IAA on DMR platforms */
  	{ PCI_DEVICE_DATA(INTEL, IAA_DMR, &idxd_driver_data[IDXD_TYPE_IAX]) },
+	/* IAX PTL platforms */
+	{ PCI_DEVICE_DATA(INTEL, IAX_PTL, &idxd_driver_data[IDXD_TYPE_IAX]) },

Use IAA going forward?
Will fix it in v2.


  	{ 0, }
  };
  MODULE_DEVICE_TABLE(pci, idxd_pci_tbl);
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 8139231d0e86..e598d6ff58bf 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -3117,6 +3117,7 @@
  #define PCI_DEVICE_ID_INTEL_HDA_CNL_H	0xa348
  #define PCI_DEVICE_ID_INTEL_HDA_CML_S	0xa3f0
  #define PCI_DEVICE_ID_INTEL_HDA_LNL_P	0xa828
+#define PCI_DEVICE_ID_INTEL_IAX_PTL	0xb02d

What is using this devid beyond the driver that needs pci_ids.h addition?

No other usage beyond the driver. Will move it inside the driver.


  #define PCI_DEVICE_ID_INTEL_S21152BB	0xb152
  #define PCI_DEVICE_ID_INTEL_HDA_BMG	0xe2f7
  #define PCI_DEVICE_ID_INTEL_HDA_PTL	0xe428

Thanks.

-Fenghua




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux