On Mon, Sep 09, 2024 at 06:09:37PM +0530, Basavaraj Natikar wrote: > Add support for AMD AE4DMA controller. It performs high-bandwidth > memory to memory and IO copy operation. Device commands are managed > via a circular queue of 'descriptors', each of which specifies source > and destination addresses for copying a single buffer of data. > > Reviewed-by: Raju Rangoju <Raju.Rangoju@xxxxxxx> > Reviewed-by: Philipp Stanner <pstanner@xxxxxxxxxx> > Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx> > --- > MAINTAINERS | 6 + > drivers/dma/amd/Kconfig | 1 + > drivers/dma/amd/Makefile | 1 + > drivers/dma/amd/ae4dma/Kconfig | 14 ++ > drivers/dma/amd/ae4dma/Makefile | 10 ++ > drivers/dma/amd/ae4dma/ae4dma-dev.c | 198 ++++++++++++++++++++++++++++ > drivers/dma/amd/ae4dma/ae4dma-pci.c | 157 ++++++++++++++++++++++ > drivers/dma/amd/ae4dma/ae4dma.h | 95 +++++++++++++ Just kibbitzing here since I don't maintain anything in this area, but IMO there's no benefit to splitting this into three tiny files. It would be easier to read the driver if everything were in a single ae4dma.c file. Bjorn
