Thanks Krzysztof for the review.
On 8/30/2024 1:41 PM, Krzysztof Kozlowski wrote:
On 29/08/2024 11:24, Mukesh Kumar Savaliya wrote:
Adds qcom,shared-se flag usage. Use this when particular I2C serial
controller needs to be shared between two subsystems.
Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
---
Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++
1 file changed, 4 insertions(+)
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Sorry, i forgot to add list for different SS. I am adding all
maintainers and list after running maintainers scripts on each patch.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
You mean flag addition into DTSI file ? If yes, then the intention was
to just enable feature support but not into mainline because it should
happen per board or usecase. Please suggest if i can enable particular
node with DTSI feature flag.
Please correct me if my understanding on your ask went wrong.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
