On 30/08/2024 11:41, Liao Yuanhong wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids the calls to clk_disable_unprepare(). > --- > v2:remove inappropriate modifications, configure COMPILE_TEST for easy > testing, add devm_clk_getprepaed() for imx sdma device. > --- > Vinod, Since ~2 weeks there is tremendous amount of trivial patches coming from vivo.com. I identified at least 6 buggy, where the contributor did not understand the code. Not sure about intention, but I advise extra carefulness when dealing with these "trivial" improvements. Best regards, Krzysztof
