On 08-07-24, 20:14, Basavaraj Natikar wrote:
> To focus on reusability of ptdma code across modules extract common
> functions into reusable modules.
>
> Reviewed-by: Raju Rangoju <Raju.Rangoju@xxxxxxx>
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> ---
> MAINTAINERS | 1 +
> drivers/dma/amd/ptdma/ptdma-dev.c | 2 +-
> drivers/dma/amd/ptdma/ptdma-dmaengine.c | 3 +--
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 539bf52410de..97d97ddf26f5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -952,6 +952,7 @@ M: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> L: dmaengine@xxxxxxxxxxxxxxx
> S: Maintained
> F: drivers/dma/amd/ae4dma/
> +F: drivers/dma/amd/common/
I think this should be made amd/ to avoid churn when a file is
added/dropped
>
> AMD AXI W1 DRIVER
> M: Kris Chaplin <kris.chaplin@xxxxxxx>
> diff --git a/drivers/dma/amd/ptdma/ptdma-dev.c b/drivers/dma/amd/ptdma/ptdma-dev.c
> index a2bf13ff18b6..2bdf418fe556 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dev.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dev.c
> @@ -17,7 +17,7 @@
> #include <linux/module.h>
> #include <linux/pci.h>
>
> -#include "ptdma.h"
> +#include "../common/amd_dma.h"
>
> /* Human-readable error strings */
> static char *pt_error_codes[] = {
> diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> index a2e7c2cec15e..66ea10499643 100644
> --- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> +++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
> @@ -9,8 +9,7 @@
> * Author: Gary R Hook <gary.hook@xxxxxxx>
> */
>
> -#include "ptdma.h"
> -#include "../../dmaengine.h"
> +#include "../common/amd_dma.h"
So the driver was including old headers and now new, but I dont see any
functions being moved? Does each patch compile...?
--
~Vinod
