Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在2024年7月17日七月 下午9:06,Huacai Chen写道:
> On Tue, Jul 16, 2024 at 9:12 PM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote:
>>
>>
>>
>> 在2024年7月16日七月 下午5:40,Huacai Chen写道:
>> > On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote:
>> >>
>> >>
>> >>
>> >> 在2024年7月15日七月 下午2:39,Huacai Chen写道:
>> >> [...]
>> >> >
>> >> >> You said that you've accepted my suggestion, which means you recognize
>> >> >> 'loongson' as the better name for the drivers.
>> >> > No, I don't think so, this is just a compromise to keep consistency.
>> >>
>> >> Folks, can we settle on this topic?
>> >>
>> >> Is this naming really important? As long as people can read actual chip name from
>> >> kernel code & documents, I think both are acceptable.
>> >>
>> >> I suggest let this patch go as is. And if anyone want to unify the naming, they can
>> >> propose a treewide patch.
>> > Renaming still breaks config files.
>>
>> This is trival with treewide sed :-)
> Please read the commit message of b8d3349803ba34afda429e87a837fd95a carefully.

We don't have 114 defconfigs don't we?

Those symbols are not frequently specified by down stream users either.

I think Keguang had tried his best on resolving all reasonable comments.

Naming is a matter of preference after all, I think we should give Keguang some respect
here.

Thanks
- Jiaxun

>
> Huacai
>
>>
>> Thanks
>> - Jiaxun
>>
>> --
>> - Jiaxun

-- 
- Jiaxun





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux