Re: [PATCH] dmaengine: qcom: bam_dma: Handle the return value of bam_dma_resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> As pm_runtime_force_resume() can return error numbers, it should be
> better to check the return value and deal with the exception.

1. Please improve such a change description with an imperative wording.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94

2. Is there a need to complete the exception handling with a clk_unprepare() call?

3. How do you think about to use a summary phrase like “Return value from
   a pm_runtime_force_resume() call in bam_dma_resume()”?

4. Were any special source code analysis tools involved from your research organisation?

Regards,
Markus





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux