On Wed, 17 Jul 2024 at 09:29, Chen Ni <nichen@xxxxxxxxxxx> wrote: > > As pm_runtime_force_resume() can return error numbers, it should be > better to check the return value and deal with the exception. > > Fixes: a39cddc9e377 ("dmaengine: pl330: Drop boilerplate code for suspend/resume") > Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Uffe > --- > drivers/dma/pl330.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index 60c4de8dac1d..624ab4eee156 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2993,9 +2993,7 @@ static int __maybe_unused pl330_resume(struct device *dev) > if (ret) > return ret; > > - pm_runtime_force_resume(dev); > - > - return ret; > + return pm_runtime_force_resume(dev); > } > > static const struct dev_pm_ops pl330_pm = { > -- > 2.25.1 > >