Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Wed, 26 Jun 2024 17:26:59 +0200
In-reply-to: <20240626082711.2826915-1-make24@iscas.ac.cn>
References: <20240626082711.2826915-1-make24@iscas.ac.cn>
Ui-outboundreport: notjunk:1;M01:P0:4z07E+GbHr4=;EM2F0C17iJdtgPPEaeqvtstul/X XdiivHXpxwOaW2YBFsSSdDuV+I65+lKwdkg3TQffDdQruWpv73VdF1BxsAa6wsVd/3Oq+C+xv trF0g6TqImPXg0se9yUC0V4QQ6t3UyPkUmLDtQuwtvG7kKixR4v+p/n1ba6KPvx7PkRwWQxgx P0EHchQ3opjdRmpb/Dj/7Hi3Cfl6g3Etx1XqNSv00prEfafDkAHMz7We2xWekO/9klXhDgV/W /fD6xOHjf0/LSHHVQcZEgQRWkSkuM2UuXttATnPWqwCRdV32MFxpflVPDN6Rfkhz9JrJMe1lt tLJwc8GYn55T1xK4wg1qRTNHAJT/cpmCjsR1bLGhy8hj+9cZRP/RIn32SqUrGrZptYNpn1YUO h3X8vcf8/2PEW1GBHgXpTDOsQYgRnnNM+gu9TA/ojq/C5qyvCuica5uQMBbfhfCtp10OnzWBU RYBLb/VnMgp7UQ8gie8b8XQTUtpemOQuSls1M8eJvaS5NdQii/+fSRn8dEpChKQyq00CgUHK5 0+GZcGkHW/iZJ5SU3D15n7+BbZEsIRtxclTloNkRnllKZHZ6mez9yefiuVFUu3zbSYV/GvHTU xMpiAc4kBsyPICkSD+bEac9yFU0e+e5cLF4kdRV2P+RR0DqDhc1jXBQ3PiQunF6PZ7uQ6RYic M8r7RB/GBFKcxj8FEVcTyjJT6zYQqB6CqMvc4Eom7JjLbKbZY5OQhRqVg5ROxUTcRrGJ+JC0n jd7bl5oc29QRo3zBpb8Jbq5ZfHW1myuaUNczYSfvQobPfWVnPDZ/xG+GyYq+foozLdSUEeESq 9NL2UJik/ZNgr1TxJ5RHBeJJXbTv/sxOi8FIA1rCebazs=
User-agent: Mozilla Thunderbird

> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().

Please avoid the repetition of a function name in such a change description.
Can it be improved with corresponding imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94

Regards,
Markus

References:
- [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
  - From: Ma Ke

Prev by Date: Re: [PATCH] dmaengine: mxs-dma: Add check for dma_set_max_seg_size in mxs_dma_probe()
Next by Date: Re: [PATCH] dmaengine: dw-axi-dmac: Add check for dma_set_max_seg_size in dw_probe()
Previous by thread: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
Next by thread: Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux PCI] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]