Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Sun, 9 Jun 2024 17:50:17 +0200
In-reply-to: <20240608213216.25087-1-olivierdautricourt@gmail.com>
References: <20240608213216.25087-1-olivierdautricourt@gmail.com>
Ui-outboundreport: notjunk:1;M01:P0:JjeO/0DjZH8=;mKAUDol7iAv61TW1DGQ/Pj321tx e9onCja0JGlN1l5tuR4ro9VryKXUcWtrmcM7akPVzG1mtV+bX3YdNStT+LdFhjCGLOvROSy1d IYj1+/zTdTiD8NHAjxbUdEiG8iDfoEKUm32Wz4WmvkauedtesyI+Tulxkm334lpnuxWfYMXji Lpjl6NT0FnLm9XPSI66bF5A7PsFdjG1DbqwULfcQUx/y0NiNSyJhEW7oKXgme2wxarUrANf9q Jskbi5SudYyWTbaKGxZhRr5sCgNdeRHs/R0i5dzMnFSC8YGltDJeaW9MB/kwFLAjbhbhvA2+D jMJRb8fhd7Vjlp89hsFgIt5RL48xGJX7CN0fm8tqdxAEmyvcISuMppq096nkx4sHIiXZ5gg/i NdPpfjWfpeabZmsCoJldsMr3v5HmQG/nJVfmXFFqq+FW+i+MWR66VlcISE5k9TLfplbt0A9nI pQDTL4ZcCrom2oFRHqXMor//7D5QGUE1V10S9gyOR4gyOCu07j1SN2l2uppo8X0+McS0APFkK 2UIhXNiM7GpI8Ggiqoffy2o7Kqyj91ArmpWoLKOngCs3hhnhYjTOMF35162s0FnY72DZRaEtU j8LsWgDd3PzQsloiPL6cTfRFqwTp2I6NJyjiifpBn0l2smDscYDW9OHTNzuHRcwbyWDlcXXLC 7GvCWBj5aMFXEeoKp4tT+WgE0U9U0qcMPlbpN/MINvMrI/9X66QiA7u7mh//mTesS00IPE3Gg z7VPPIKl/UdsUTEA/eJvcBYeuVm4VukgjZMJ+IzYlGVNXdjBDTY3p+jyI7lXr771dc4lJZ7Xp EDgo+6EjBVA1Wwb+MsCBd02YrpnkEeuMA8xYBwjjluf3k=
User-agent: Mozilla Thunderbird

I find that a cover letter can be helpful for the presented patch series.


> As we first take the lock with spin_lock_irqsave in msgdma_tasklet, Lockdep
…

I suggest to move the last word into the subsequent text line.

Regards,
Markus

References:
- [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks
  - From: Olivier Dautricourt

Prev by Date: Re: [PATCH v10 0/6] iio: new DMABUF based API v10
Next by Date: Re: [PATCH net-next] dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq()
Previous by thread: Re: [PATCH v2 3/3] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor
Next by thread: Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux PCI] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]